-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ipv6 link-local address #2660
base: master
Are you sure you want to change the base?
feat: support ipv6 link-local address #2660
Conversation
56755fb
to
0639a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why a well-behaved peer would ever advertise an ip6zone address? I can’t see any, but I might be missing something.
If that’s the case, we don’t need to make any changes to the TCP transport.
As an example, an IoT node before IP is set can use it to communicate via p2p. Since link-local address cannot be used on the Internet, it was intentionally excluded from announce. |
What do you mean by „before the IP address is set“? Are you referring to DHCP? How would and ip6zone address passed to the TCP transport look like? |
@marten-seemann |
Can you just advertise /ip6/fe80::3811:2aff:fe94:adbe/tcp/1234? For the peer, it’s irrelevant that it’s on your eth0 interface, right? |
0639a3a
to
1f421f9
Compare
@marten-seemann Currently, link-local addresses are intentionally excluded from basic_host. |
I don't understand how this would work. What is configured to be eth0 is only relevant to me, not to the remote node. Therefore, we should never advertise it. |
Please don't reply here. Let's move discussion of this back to the issue: #2659. |
1f421f9
to
f1a42fe
Compare
I'm adding the blocked label here, since there's little point in moving this PR forward until we've resolved libp2p/zeroconf#35. Once that has been done, we still need to decide if support IPv6 link-local is something we want to do, see #2659 (comment). |
Close #2659 .
Make it possible to connect to the link-local address.
Note that
To work with mdns, must also modify https://github.com/libp2p/zeroconf.